tarry.singh/Radix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Switch ZML to use .host_pinned memory on ROCm, addressing missing host_unpinned memory error.

Browse Source
This commit is contained in:
Tarry Singh 2025-12-01 14:34:13 +00:00
parent 7894335dc9
commit ba5043ddf8
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
zml/platform.zig
View File

@ -89,7 +89,9 @@ pub const Platform = struct {
const memory_target: pjrt.Memory.Kind = switch (memory) { const memory_target: pjrt.Memory.Kind = switch (memory) {
.host_unpinned => switch (platform.target) { .host_unpinned => switch (platform.target) {
// Cuda doesn't have host_unpinned. // Cuda doesn't have host_unpinned.
.cuda => .host_pinned, // ROCm doesn't seem to have it either.
// TODO(gwenzek): investigate why it was not forced before.
.cuda, .rocm => .host_pinned,
else => .host_unpinned, else => .host_unpinned,
}, },
inline else => |t| t, inline else => |t| t,