tarry.singh/Radix
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Async: use stronger memory ordering to prevent potential segfaults due to ordering issues.

Browse Source
This commit is contained in:
Tarry Singh 2025-02-18 11:38:56 +00:00
parent 4d6d975dc0
commit a580f2a398
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
async/async.zig
View File

@ -121,15 +121,15 @@ pub const threading = struct {
waiter: std.atomic.Value(*const State) = std.atomic.Value(*const State).init(&State.unset_state), waiter: std.atomic.Value(*const State) = std.atomic.Value(*const State).init(&State.unset_state),
pub fn isSet(self: *ResetEventSingle) bool { pub fn isSet(self: *ResetEventSingle) bool {
return self.waiter.load(.monotonic) == &State.set_state; return self.waiter.load(.seq_cst) == &State.set_state;
} }
pub fn reset(self: *ResetEventSingle) void { pub fn reset(self: *ResetEventSingle) void {
self.waiter.store(&State.unset_state, .monotonic); self.waiter.store(&State.unset_state, .seq_cst);
} }
pub fn set(self: *ResetEventSingle) void { pub fn set(self: *ResetEventSingle) void {
switch (self.waiter.swap(&State.set_state, .monotonic).*) { switch (self.waiter.swap(&State.set_state, .seq_cst).*) {
.waiting => |waiter| { .waiting => |waiter| {
waiter.thread.waiters_queue.push(waiter); waiter.thread.waiters_queue.push(waiter);
waiter.thread.wake(); waiter.thread.wake();
@ -146,7 +146,7 @@ pub const threading = struct {
var new_state: State = .{ var new_state: State = .{
.waiting = &waiter, .waiting = &waiter,
}; };
if (self.waiter.cmpxchgStrong(&State.unset_state, &new_state, .monotonic, .monotonic) == null) { if (self.waiter.cmpxchgStrong(&State.unset_state, &new_state, .seq_cst, .seq_cst) == null) {
while (self.isSet() == false) { while (self.isSet() == false) {
coro.xsuspend(); coro.xsuspend();
} }